GH4286: Update DotNetToolRunner to append command using quotes#4537
Merged
devlead merged 1 commit intocake-build:developfrom Aug 6, 2025
Merged
Conversation
2 tasks
Contributor
Author
|
@microsoft-github-policy-service agree company="Mando Group" |
2 tasks
Member
|
@antonysmith-mandogroup your changes have been merged, thanks for your contribution 👍 |
This was referenced Oct 5, 2025
This was referenced Nov 1, 2025
This was referenced Nov 12, 2025
2 tasks
This was referenced Nov 24, 2025
This was referenced Dec 11, 2025
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion in #4286, this PR resolves an issue where the command passed to DotNetToolRunner is the path of an application to run and it contains whitespace.
Sample verbose output before this change:
Output following the change - note the surrounding quotes around the application being run:
All unit tests (that I can run on my Windows machine) pass:
This includes a new test I have added to verify that the command is now quoted.