Skip to content

Add empty state for deprecations #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstory merged 2 commits into from
May 28, 2024
Merged

Add empty state for deprecations #1004

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1b5335
Add empty state for deprecations
markstory May 27, 2024
674524d
Apply suggestions from code review
markstory May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion templates/element/deprecations_panel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

use function Cake\Core\h;

$hasAny = count($app) + count($plugins) + count($cake) . count($vendor);
Comment thread
markstory marked this conversation as resolved.
Outdated

$printer = function ($section, $data) {
?>
<h3><?= h(ucfirst($section)) ?> </h3>
Expand All @@ -39,7 +41,11 @@
}
?>
<div class="c-deprecations-panel">
<?php
<?php if ($hasAny) : ?>
<p class="c-flash c-flash--info">No deprecations</p>
<?php
endif;

if (count($app)) :
$printer('app', $app);
endif;
Expand Down