-
Notifications
You must be signed in to change notification settings - Fork 24
feat: allow building on other compatible architectures #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8d39df1
ci: run tests on arm64 and Python 3.14
lengau a1e5a27
fix: no 3.14 for now
lengau 1523618
fix: project tests
lengau 0bc8722
fix: disable fetch service tests that are too complex to fix right now
lengau 8c2ccf8
fix(tests): managed grammar test
lengau 37d387a
feat: allow building on other compatible architectures
lengau 356dd24
ci: run spread tests on arm too
lengau cc5626d
fix(test): add instance architecture to unit tests
lengau 0163d00
ci: fix spread builds
lengau cd61d60
ci: simplify multiarch spread
lengau 9c50772
fix(spread): arm runners not working properly
lengau 36064b6
docs: add changelog entry
lengau 7c6f9b1
fix: rstrip
lengau 08a5cf8
ci: reset spread tests back to the normal
lengau 367e540
Merge branch 'main' into work/CRAFT-4992
lengau 32df469
Merge branch 'main' into work/CRAFT-4992
lengau 403190b
Apply suggestions from code review
lengau 69c9653
Apply suggestions from code review
lengau 9cf7c50
Apply suggestions from code review
lengau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| summary: Testcraft can build on armhf on an arm64 runner | ||
|
|
||
| priority: 100 | ||
|
|
||
| systems: | ||
| - ubuntu-24.04-arm-64 | ||
|
lengau marked this conversation as resolved.
|
||
|
|
||
| execute: | | ||
| # Configure testcraft to build on armhf | ||
| export CRAFT_BUILD_ON=armhf | ||
|
|
||
| testcraft pack --verbosity=debug | ||
| test -f built-on-armhf-0.1-platform-independent.testcraft | ||
|
|
||
| restore: | | ||
| testcraft clean | ||
| rm -f built-on-armhf*.testcraft | ||
16 changes: 16 additions & 0 deletions
16
tests/spread/testcraft/different-architecture/testcraft.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: built-on-armhf | ||
| summary: A testcraft package that gets built on an armhf runner. | ||
| version: "0.1" | ||
|
|
||
| base: ubuntu@24.04 | ||
| platforms: | ||
| platform-independent: | ||
| build-on: [armhf] | ||
| build-for: [all] | ||
|
|
||
| parts: | ||
| my-test: | ||
| plugin: nil | ||
| override-build: | | ||
| echo -e "#!/bin/bash\necho Hello, world!" > $CRAFT_PART_INSTALL/hello | ||
| chmod a+x $CRAFT_PART_INSTALL/hello |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.