Skip to content

feat: add circle-of-friends icon and branded chip component#5774

Open
mariadias143 wants to merge 7 commits intocanonical:mainfrom
mariadias143:WD-31528
Open

feat: add circle-of-friends icon and branded chip component#5774
mariadias143 wants to merge 7 commits intocanonical:mainfrom
mariadias143:WD-31528

Conversation

@mariadias143
Copy link

@mariadias143 mariadias143 commented Mar 17, 2026

Done

  • Creates branded chip component based on figma specification
  • Adds Circle of Friends icon to standard icons
  • Removed design guideline that prohibits usage of chip component for branding. If this were to be updated to a "when to use" scenario, then I would need a new image and description to go with.
  • Drive by: fix links in CTA section which were breaking linkchecker CI step (caused by changes in the last merged PR)

Fixes #5699

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

image image image image image image image

@webteam-app
Copy link

@mariadias143 mariadias143 marked this pull request as ready for review March 17, 2026 12:32
@mariadias143 mariadias143 changed the title feat: add circle-of-friends icon and branded chip component variant feat: add circle-of-friends icon and branded chip component Mar 17, 2026
@jmuzina jmuzina self-assigned this Mar 17, 2026
@jmuzina jmuzina added the Review: Percy needed This PR needs a review of Percy for visual regressions label Mar 17, 2026
@diana-stanciulescu
Copy link

@mariadias143 thanks! The icon-only version should be a perfect circle. Othewr than this, this looks great.
I assume users can change the text if needed? Product managers may have different needs too.

@mariadias143
Copy link
Author

mariadias143 commented Mar 17, 2026

@mariadias143 thanks! The icon-only version should be a perfect circle. Othewr than this, this looks great. I assume users can change the text if needed? Product managers may have different needs too.

@diana-stanciulescu Yes, users can use whatever text they would like. Regarding the chip not being a perfect circle, I think one of the screenshots I added in the PR description (second one specifically) looked weird because of my monitor but it looks good on my laptop (see below). I updated the screenshot in the description as well. What do you think?

24 × 24 ACCESSIBILITY Pasted Graphic 2

@diana-stanciulescu
Copy link

@mariadias143 thanks for checking, the circle part seems ok, but what I noticed now is the icon looks small , can you please double check:

Screenshot 2026-03-17 175348

@mariadias143
Copy link
Author

mariadias143 commented Mar 18, 2026

@mariadias143 thanks for checking, the circle part seems ok, but what I noticed now is the icon looks small , can you please double check:

Screenshot 2026-03-17 175348

@diana-stanciulescu can you check again? It should be fixed now
previously:
i p-icon--circle-of-friends 16×16

with latest changes:
ACCESSIBILITY

@@ -0,0 +1,26 @@
{% extends "_layouts/examples.html" %}
{% block title %}Chip / Branded{% endblock %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example has the same title as your other example, so they're indistinguishable on the examples list:

Image

Comment on lines +3 to +4
- component: Branded chip
url: /docs/patterns/chip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally keep the release notes entry titles to match the name of a docs page (a component, base element, pattern, etc). Then use the url and notes to lead the user to what specifically was changed there.

Suggested change
- component: Branded chip
url: /docs/patterns/chip
- component: Chip
url: /docs/patterns/chip#branded-chip-new

("new") is included in the URL due to this issue not being solved yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature 🎁 New feature or request Review: Code needed Review: Design needed Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New component]: <Branded chip>

4 participants