feat: add circle-of-friends icon and branded chip component#5774
feat: add circle-of-friends icon and branded chip component#5774mariadias143 wants to merge 7 commits intocanonical:mainfrom
Conversation
|
@mariadias143 thanks! The icon-only version should be a perfect circle. Othewr than this, this looks great. |
@diana-stanciulescu Yes, users can use whatever text they would like. Regarding the chip not being a perfect circle, I think one of the screenshots I added in the PR description (second one specifically) looked weird because of my monitor but it looks good on my laptop (see below). I updated the screenshot in the description as well. What do you think?
|
|
@mariadias143 thanks for checking, the circle part seems ok, but what I noticed now is the icon looks small , can you please double check:
|
@diana-stanciulescu can you check again? It should be fixed now |
| @@ -0,0 +1,26 @@ | |||
| {% extends "_layouts/examples.html" %} | |||
| {% block title %}Chip / Branded{% endblock %} | |||
| - component: Branded chip | ||
| url: /docs/patterns/chip |
There was a problem hiding this comment.
We generally keep the release notes entry titles to match the name of a docs page (a component, base element, pattern, etc). Then use the url and notes to lead the user to what specifically was changed there.
| - component: Branded chip | |
| url: /docs/patterns/chip | |
| - component: Chip | |
| url: /docs/patterns/chip#branded-chip-new |
("new") is included in the URL due to this issue not being solved yet







Done
Fixes #5699
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots