Open
Conversation
e5277d6 to
d461d15
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Search and Filter pattern’s “expanded” styling state to stop (mis)using aria-expanded on the search container, replacing it with a data-expanded attribute, and publishes the change via a new release entry/version bump.
Changes:
- Updated Search and Filter SCSS selectors to use
data-expandedinstead ofaria-expanded. - Added a 4.47.0 release note describing the attribute change.
- Bumped the package version to 4.47.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scss/_patterns_search-and-filter.scss |
Switches styling hooks from aria-expanded to data-expanded for the search container. |
releases.yml |
Adds release-note entry documenting the attribute change. |
package.json |
Bumps version from 4.46.0 to 4.47.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d461d15 to
aca7d3d
Compare
Author
|
There is also one more thing here: in the docs, we still set aria-expanded on individual chips. This is incorrect, and is removed from react-components here. It is however out of scope for this PR, but could still be corrected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
This is **closely related to this ** PR.
QA
This is the dummy app I used in testing:
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention