Skip to content

fix: a11y low contrast in dark mode for code [AC-4348]#5777

Open
Stefan3002 wants to merge 1 commit intocanonical:mainfrom
Stefan3002:fix-a11y-low-contrast-code
Open

fix: a11y low contrast in dark mode for code [AC-4348]#5777
Stefan3002 wants to merge 1 commit intocanonical:mainfrom
Stefan3002:fix-a11y-low-contrast-code

Conversation

@Stefan3002
Copy link

@Stefan3002 Stefan3002 commented Mar 19, 2026

Done

  • Increased the contrast for the code element in dark mode.
  • Screenshots show it was too low.
  • The contrast is 5.13 now.

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]
      Look at a confirmation modal that says: Next time press SHIFT, the contrast of the SHIFT text should be increased and pass a11y guidelines

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Fixes: AC-4348

Screenshots

image

@webteam-app
Copy link

@Stefan3002 Stefan3002 changed the title fix a11y low contrast in dark mode for code fix: a11y low contrast in dark mode for code Mar 19, 2026
@Stefan3002 Stefan3002 changed the title fix: a11y low contrast in dark mode for code fix: a11y low contrast in dark mode for code [AC-4348] Mar 19, 2026
@jmuzina jmuzina self-requested a review March 19, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants