Skip to content

Remove express dependency#68

Merged
danjoa merged 2 commits intomainfrom
express-deps
Jan 15, 2026
Merged

Remove express dependency#68
danjoa merged 2 commits intomainfrom
express-deps

Conversation

@danjoa
Copy link
Contributor

@danjoa danjoa commented Jan 15, 2026

  1. The rule is: you need to add dependencies to the packages you import / require in your code.
  2. We don't have such direct usage in our code base in cds-test.
  3. If (1) holds true, and (2) as well ⇒ we should not need that dependency, correct?
  4. @sap/cds needs express, and it brings it with its dependencies, doesn't it?

@danjoa danjoa requested a review from sjvans January 15, 2026 17:11
@danjoa danjoa enabled auto-merge (squash) January 15, 2026 17:13
Copy link
Member

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I guess express was here for the our own tests only, assuming npm doesn't install it with sap/cds. But that changed somewhen, so that express is there.

@danjoa danjoa merged commit c4127ca into main Jan 15, 2026
3 checks passed
@danjoa danjoa deleted the express-deps branch January 15, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants