Open
Conversation
| build: | ||
| context: . | ||
| target: base | ||
| init: true |
Contributor
Author
There was a problem hiding this comment.
(not related) This is just to make the container stop faster. Without it it looks like signals (SIGINT, etc..) are not forwarded to tail thus making docker wait for a timeout before killing the container.
alexandre-abrioux
force-pushed
the
eip-1559
branch
from
21ba5b9 to
581d4f5
Compare
Contributor
Author
|
Update: I also added a gas price spike protection, to prevent being impacted by a huge gas price surge like what happened this morning. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Hi! This PR adds three strategies for gas price prediction:
eip-1559-urgenteip-1559-fasteip-1559-normalThose three strategies correspond to three recommendations resulting from calling the
suggestFees()method of the eip1559-fee-suggestions-ethers library. Under the hood this library uses the neweth_feeHistorymethod introduced in the ethereum/execution-apis spec after EIP-1559.Technical details / Misc.
TransactionManagerclass that takes care of common overrides for all transactions made by the node, except for theretire()call because this one is a little special and cannot work with EIP-1559 in its current implementation (I think).ethersand did ayarn updatein order to have only one version ofethersin theyarn.lockfile.README.md, feel free to make edits!I have been running this without any issue for the past month. I'm pretty satisfied!
Please let me know if you would like to see this feature implemented in another way or with a different architecture, I'll be glad to adapt the code. And again, thank you for this amazing project 🙂