fix: don't post non-actionable errors as GitHub review comments#189
Open
JosephDoUrden wants to merge 1 commit intocased:mainfrom
Open
fix: don't post non-actionable errors as GitHub review comments#189JosephDoUrden wants to merge 1 commit intocased:mainfrom
JosephDoUrden wants to merge 1 commit intocased:mainfrom
Conversation
…d#114) When the LLM provider returns a token-limit, context-length, HTTP 5xx, or rate-limit error, skip posting it as a PR comment and show the error locally instead. A centralized is_non_actionable_error() helper detects these infrastructure failures by checking for known error prefixes combined with provider error patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_non_actionable_error()helper insrc/kit/pr_review/error_utils.pyto classify token-limit, context-length, HTTP 5xx, and rate-limit errors as non-actionablepost_pr_comment()in bothPRReviewerandAgenticPRReviewerso these errors are shown locally instead of posted to GitHubRoot cause
The enhanced LLM analysis methods catch provider exceptions and return error strings (e.g.
Error during enhanced LLM analysis: 502 Bad Gateway). These strings were previously treated as normal review output and blindly posted to GitHub viapost_pr_comment().Test plan
post_pr_comment()is NOT called for 5xx/token errorspost_pr_comment()IS called for successful reviewsCloses #114