refactor(tests): Use Parameterized tests to test all flavors#34
Open
thelooter wants to merge 2 commits intocatppuccin:mainfrom
Open
refactor(tests): Use Parameterized tests to test all flavors#34thelooter wants to merge 2 commits intocatppuccin:mainfrom
thelooter wants to merge 2 commits intocatppuccin:mainfrom
Conversation
Refactor tests in `PaletteTests.java` to use parameterized tests. * Refactor `mochaExistsAndReturnsCorrectDetails`, `frappeExistsAndReturnsCorrectDetails`, `macchiatoExistsAndReturnsCorrectDetails`, and `latteExistsAndReturnsCorrectDetails` into a single parameterized test `flavorExistsAndReturnsCorrectDetails`. * Add `provideFlavors` method to supply arguments for the parameterized test. * Refactor `darkLightSet` test to use parameterized test and constants from `com.catppuccin.Palette`. * Add `provideDarkLightFlavors` method to supply arguments for the `darkLightSet` parameterized test.
* Add `junit-jupiter-params` dependency under `<dependencies>` section for parameterized tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
palettemodule, focusing on enhancing the test suite by introducing parameterized tests and adding new dependencies for testing. The most important changes include adding thejunit-jupiter-paramsdependency to thepom.xmlfile and refactoring the test cases inPaletteTests.javato use parameterized tests.Added libraries:
palette/pom.xml: Added thejunit-jupiter-paramsdependency to support parameterized tests.Refactoring test cases:
palette/src/test/java/com/catppuccin/PaletteTests.java: Replaced individual test methods for each flavor with a single parameterized test methodflavorExistsAndReturnsCorrectDetailsto test multiple flavors.palette/src/test/java/com/catppuccin/PaletteTests.java: Replaced thedarkLightSettest method with a parameterized version to test the light and dark properties of multiple flavors.