Skip to content

fix(twitter): fix chat #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
watatomo wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

fix(twitter): fix chat #2236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3edd18
fix(twitter): fix chat
watatomo Apr 26, 2026
184419c
Merge branch 'main' into main
watatomo May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions styles/twitter/catppuccin.user.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,21 @@
#lib.defaults();

body.LightsOut {
--background: #lib.hslify(@base)[];
--border-color: @surface0;
--color: @overlay1;
--color-emphasis: @text;
--hover-bg-color: @surface0;
--cpft-text-primary: @text;
--color-gray-0: #lib.hslify(@surface0)[];
--color-text: #lib.hslify(@text)[];
--color-gray-100: #lib.hslify(@surface1)[];
--color-gray-700: #lib.hslify(@overlay0)[];
--primary: #lib.hslify(@accent)[];
Comment on lines +38 to +48
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#lib.hslify() expands to a comma-separated HSL triplet (see lib/lib.less:95-99). If Twitter’s new Chat styles consume --background via modern syntax like hsl(var(--background) / <alpha>), the commas will make the color invalid and the theming won’t apply. Consider switching to a space-separated HSL helper (used in other styles in this repo) or to #lib.rgbify() if the upstream CSS expects rgb(var(--...)) tokens.

Suggested change
--background: #lib.hslify(@base)[];
--border-color: @surface0;
--color: @overlay1;
--color-emphasis: @text;
--hover-bg-color: @surface0;
--cpft-text-primary: @text;
--color-gray-0: #lib.hslify(@surface0)[];
--color-text: #lib.hslify(@text)[];
--color-gray-100: #lib.hslify(@surface1)[];
--color-gray-700: #lib.hslify(@overlay0)[];
--primary: #lib.hslify(@accent)[];
@base-h: hue(@base);
@base-s: saturation(@base);
@base-l: lightness(@base);
@background-hsl: ~"@{base-h} @{base-s} @{base-l}";
@surface0-h: hue(@surface0);
@surface0-s: saturation(@surface0);
@surface0-l: lightness(@surface0);
@surface0-hsl: ~"@{surface0-h} @{surface0-s} @{surface0-l}";
@text-h: hue(@text);
@text-s: saturation(@text);
@text-l: lightness(@text);
@text-hsl: ~"@{text-h} @{text-s} @{text-l}";
@surface1-h: hue(@surface1);
@surface1-s: saturation(@surface1);
@surface1-l: lightness(@surface1);
@surface1-hsl: ~"@{surface1-h} @{surface1-s} @{surface1-l}";
@overlay0-h: hue(@overlay0);
@overlay0-s: saturation(@overlay0);
@overlay0-l: lightness(@overlay0);
@overlay0-hsl: ~"@{overlay0-h} @{overlay0-s} @{overlay0-l}";
@accent-h: hue(@accent);
@accent-s: saturation(@accent);
@accent-l: lightness(@accent);
@accent-hsl: ~"@{accent-h} @{accent-s} @{accent-l}";
--background: @background-hsl;
--border-color: @surface0;
--color: @overlay1;
--color-emphasis: @text;
--hover-bg-color: @surface0;
--cpft-text-primary: @text;
--color-gray-0: @surface0-hsl;
--color-text: @text-hsl;
--color-gray-100: @surface1-hsl;
--color-gray-700: @overlay0-hsl;
--primary: @accent-hsl;

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@uncenter uncenter Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. We do need to add a new helper for space separated, but we don't have that yet.

Copy link
Copy Markdown
Member Author

@watatomo watatomo Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know why it did this tbh


.bg-primary .text-white {
color: if(@flavor = latte, #fff, @crust);
}

// shadows
.r-qo02w8,
Expand Down Expand Up @@ -107,6 +117,11 @@
background-color: @base;
}

// text bg color
.r-1otebnk {
background-color: @text;
}

// arrow on account switcher
.r-cqee49 {
color: @base;
Expand Down
Loading