[CDAP-18995] Add env var support across all CDAP services#86
Merged
Conversation
ghost
reviewed
Mar 31, 2022
ghost
reviewed
Mar 31, 2022
ghost
reviewed
Mar 31, 2022
dli357
force-pushed
the
feature/CDAP-18995-Env
branch
from
e399265 to
be40598
Compare
ghost
reviewed
Apr 1, 2022
ghost
approved these changes
Apr 1, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. Remember to squash commits before merging.
[CDAP-18995] Switched to using maps and added unit test
dli357
force-pushed
the
feature/CDAP-18995-Env
branch
from
be40598 to
81e90b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an
envfield in the CDAPMasterSpec which applies a set of environment variables across all CDAP master services. This helps reduce configuration duplication.