Skip to content

Adding support to provide custom labels to sequence classification#41

Merged
cdpierse merged 3 commits intocdpierse:devfrom
lalitpagaria:support_custom_id2label
May 17, 2021
Merged

Adding support to provide custom labels to sequence classification#41
cdpierse merged 3 commits intocdpierse:devfrom
lalitpagaria:support_custom_id2label

Conversation

@lalitpagaria
Copy link
Contributor

To complete #25

@lalitpagaria
Copy link
Contributor Author

@cdpierse Can you please review PR

@cdpierse cdpierse self-requested a review May 17, 2021 13:55
@cdpierse cdpierse self-assigned this May 17, 2021
@cdpierse cdpierse added the enhancement New feature or request label May 17, 2021
@cdpierse cdpierse linked an issue May 17, 2021 that may be closed by this pull request
@cdpierse cdpierse changed the base branch from master to dev May 17, 2021 14:26
@cdpierse cdpierse changed the base branch from dev to master May 17, 2021 14:26
@cdpierse cdpierse changed the base branch from master to dev May 17, 2021 14:28
Copy link
Owner

@cdpierse cdpierse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lalitpagaria thank you very much for this PR, it's a great addition to the classification explainer and one I've wanted to add for a while, so I really appreciate it.

I've left one request for a minor change to be made to the docstring but besides that the rest looks good. The implementation is really clean.

I'm also currently using the black formatter for the entire repo so once you have the next change done could you run black . from the project's root.

Thanks also for writing the additional tests, it's a big help in getting things merged quicker.

@lalitpagaria
Copy link
Contributor Author

Thanks for the review. Updated PR with suggested changes ie doc string and black formatting.

@cdpierse
Copy link
Owner

Amazing work. This is a fantastic PR thanks @lalitpagaria. I'm merging this into dev now and this will be part of the next release 0.4.0 which should hopefully be within the next 2 weeks.

@cdpierse cdpierse merged commit 08217b9 into cdpierse:dev May 17, 2021
@lalitpagaria lalitpagaria deleted the support_custom_id2label branch May 18, 2021 03:00
@lalitpagaria
Copy link
Contributor Author

Thanks @cdpierse for this amazing tool
I want to integrate use it with https://github.com/lalitpagaria/obsei
So user able to interpret prediction made by AI models like zero shot, sentiment or NER etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add option to enter custom id2label dicts in init

2 participants

Comments