Adding support to provide custom labels to sequence classification#41
Adding support to provide custom labels to sequence classification#41cdpierse merged 3 commits intocdpierse:devfrom lalitpagaria:support_custom_id2label
Conversation
|
@cdpierse Can you please review PR |
cdpierse
left a comment
There was a problem hiding this comment.
@lalitpagaria thank you very much for this PR, it's a great addition to the classification explainer and one I've wanted to add for a while, so I really appreciate it.
I've left one request for a minor change to be made to the docstring but besides that the rest looks good. The implementation is really clean.
I'm also currently using the black formatter for the entire repo so once you have the next change done could you run black . from the project's root.
Thanks also for writing the additional tests, it's a big help in getting things merged quicker.
|
Thanks for the review. Updated PR with suggested changes ie doc string and black formatting. |
|
Amazing work. This is a fantastic PR thanks @lalitpagaria. I'm merging this into dev now and this will be part of the next release 0.4.0 which should hopefully be within the next 2 weeks. |
|
Thanks @cdpierse for this amazing tool |
To complete #25