Skip to content

feat: wire module-by-hash debug command#4453

Merged
evan-forbes merged 8 commits into
celestiaorg:mainfrom
01builders:julien/v3-debug-module-by-hash
Mar 28, 2025
Merged

feat: wire module-by-hash debug command#4453
evan-forbes merged 8 commits into
celestiaorg:mainfrom
01builders:julien/v3-debug-module-by-hash

Conversation

@julienrbrt
Copy link
Copy Markdown
Collaborator

Comment thread go.mod Outdated
@julienrbrt julienrbrt marked this pull request as ready for review March 27, 2025 12:48
@julienrbrt julienrbrt requested a review from a team as a code owner March 27, 2025 12:48
@julienrbrt julienrbrt requested review from ninabarbakadze and rootulp and removed request for a team March 27, 2025 12:48
@julienrbrt julienrbrt added the backport:v3.x PR will be backported automatically to the v3.x branch upon merging label Mar 27, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2025

📝 Walkthrough

Walkthrough

This pull request introduces modifications to the command initialization in the application's main command file. The initRootCommand function now creates a debugCmd variable with an additional command for querying module hashes by height. Additionally, the dependency version for github.com/cosmos/cosmos-sdk in the go.mod file has been updated to a more specific version.

Changes

File(s) Change Summary
cmd/.../root.go Modified the initRootCommand function to initialize a new debugCmd and add the server.ModuleHashByHeightQuery(NewAppServer) command.
go.mod Updated the replace directive for the github.com/cosmos/cosmos-sdk dependency to v1.28.0-sdk-v0.46.16.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant RC as RootCommand
    participant DC as DebugCmd
    participant MHQ as ModuleHashQuery

    U->>RC: Execute debug command
    RC->>DC: Process debug command
    DC->>MHQ: Execute ModuleHashByHeightQuery(NewAppServer)
    MHQ-->>DC: Return query result
    DC-->>RC: Forward result
    RC-->>U: Display output
Loading

Possibly related PRs

Suggested reviewers

  • rach-id
  • cmwaters
  • evan-forbes
  • ninabarbakadze

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c74e34f and 4f959c1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: docker-txsim-build / docker-build (GHCR; ghcr.io/celestiaorg/txsim)
  • GitHub Check: docker-security-build / docker-build (GHCR; ghcr.io/celestiaorg/celestia-app)
  • GitHub Check: test / test-fuzz
  • GitHub Check: test / test-race
  • GitHub Check: test / test-short
  • GitHub Check: test / test
  • GitHub Check: test / test-coverage
  • GitHub Check: lint / golangci-lint
  • GitHub Check: Summary

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp
Copy link
Copy Markdown
Collaborator

rootulp commented Mar 27, 2025

Pending celestiaorg/cosmos-sdk#433

That PR merged. Do you need us to create a celestiaorg/cosmos-sdk release so that this PR can bump to it?

Comment thread go.mod Outdated
Co-authored-by: Rootul P <rootulp@gmail.com>
@celestia-bot celestia-bot requested a review from rootulp March 28, 2025 07:45
@evan-forbes evan-forbes merged commit 13db506 into celestiaorg:main Mar 28, 2025
mergify Bot pushed a commit that referenced this pull request Mar 28, 2025
Pending celestiaorg/cosmos-sdk#433

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
(cherry picked from commit 13db506)
@julienrbrt julienrbrt deleted the julien/v3-debug-module-by-hash branch March 28, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:v3.x PR will be backported automatically to the v3.x branch upon merging external

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants