docs: fix broken external links in snapshots and blobstream pages#2430
docs: fix broken external links in snapshots and blobstream pages#2430
Conversation
Summary of ChangesHello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and accuracy of the documentation by resolving issues with external links. It specifically targets links that were either failing TLS checks or returning HTTP 403 errors, ensuring that users and automated systems encounter fewer broken references. The changes aim to provide a more stable and trustworthy resource without removing valuable information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes broken external links in the documentation by removing links that are failing automated checks. The changes in blobstream/integrate-contracts/page.mdx remove links to Arbiscan, and the changes in snapshots/page.mdx remove links for QubeLabs snapshots. The changes are correct and address the issue described. I've added a few suggestions to preserve the removed URLs in comments within the source files. This improves maintainability by making it easier for future contributors to check if the links have been fixed and can be restored, without affecting the link checker or the rendered output.
| | -------------- | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------------ | -------------------------------------------------------------------------------------- | | ||
| | SP1 Blobstream | Ethereum Mainnet | [`0x7Cf3876F681Dbb6EdA8f6FfC45D66B996Df08fAe`](https://etherscan.io/address/0x7Cf3876F681Dbb6EdA8f6FfC45D66B996Df08fAe#events) | [Mainnet Beta](/operate/networks/mainnet-beta) | [Deployment on Celenium](https://celenium.io/blobstream?network=ethereum&page=1) | | ||
| | SP1 Blobstream | Arbitrum One | [`0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794`](https://arbiscan.io/address/0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794#events) | [Mainnet Beta](/operate/networks/mainnet-beta) | [Deployment on Celenium](https://celenium.io/blobstream?network=arbitrum&page=1) | | ||
| | SP1 Blobstream | Arbitrum One | `0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794` | [Mainnet Beta](/operate/networks/mainnet-beta) | [Deployment on Celenium](https://celenium.io/blobstream?network=arbitrum&page=1) | |
There was a problem hiding this comment.
While removing the link fixes the automated checks, it's a good practice to keep the original URL available for maintainers. You can add it in a JSX comment so it doesn't affect the link checker or the rendered output. This will help if the link becomes stable again in the future.
| SP1 Blobstream | Arbitrum One | `0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794`{/* https://arbiscan.io/address/0xA83ca7775Bc2889825BcDeDfFa5b758cf69e8794#events */} | [Mainnet Beta](/operate/networks/mainnet-beta) | [Deployment on Celenium](https://celenium.io/blobstream?network=arbitrum&page=1) |
| | SP1 Blobstream | Scroll | [`0x5008fa5CC3397faEa90fcde71C35945db6822218`](https://scrollscan.com/address/0x5008fa5CC3397faEa90fcde71C35945db6822218) | [Mainnet Beta](/operate/networks/mainnet-beta) | N/A | | ||
| | SP1 Blobstream | Sepolia | [`0xf0c6429ebab2e7dc6e05dafb61128be21f13cb1e`](https://sepolia.etherscan.io/address/0xf0c6429ebab2e7dc6e05dafb61128be21f13cb1e#events) | [Mocha testnet](/operate/networks/mocha-testnet) | [Deployment on Celenium](https://mocha.celenium.io/blobstream?network=ethereum&page=1) | | ||
| | SP1 Blobstream | Arbitrum Sepolia | [`0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2`](https://sepolia.arbiscan.io/address/0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2#events) | [Mocha testnet](/operate/networks/mocha-testnet) | [Deployment on Celenium](https://mocha.celenium.io/blobstream?network=arbitrum&page=1) | | ||
| | SP1 Blobstream | Arbitrum Sepolia | `0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2` | [Mocha testnet](/operate/networks/mocha-testnet) | [Deployment on Celenium](https://mocha.celenium.io/blobstream?network=arbitrum&page=1) | |
There was a problem hiding this comment.
Similar to the above, consider adding the removed Arbiscan link in a JSX comment to preserve it for future reference. This helps with maintainability.
| SP1 Blobstream | Arbitrum Sepolia | `0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2`{/* https://sepolia.arbiscan.io/address/0xc3e209eb245Fd59c8586777b499d6A665DF3ABD2#events */} | [Mocha testnet](/operate/networks/mocha-testnet) | [Deployment on Celenium](https://mocha.celenium.io/blobstream?network=arbitrum&page=1) |
| | TTT | [Pruned](https://services.tienthuattoan.com/mainnet/celestia/snapshot) | - | | ||
| | Noders | [Pruned](https://noders.services/mainnet-networks/celestia/snapshot/) | - | | ||
| | QubeLabs | [Archive](https://snaps.qubelabs.io/celestia/) | - | | ||
| | QubeLabs | - | - | |
There was a problem hiding this comment.
It's good practice to keep the removed link in a comment for future reference, especially since the removal is due to a potentially temporary issue (TLS checks failing). This makes it easier for future maintainers to check if the link is working again and restore it. You can use a JSX comment.
| QubeLabs | -{/* Archive: https://snaps.qubelabs.io/celestia/ */} | - |
| | kjnodes | [Pruned](https://services.kjnodes.com/testnet/celestia/snapshot/) | - | | ||
| | Noders | [Pruned](https://noders.services/testnet-networks/celestia/snapshot) | - | | ||
| | QubeLabs | [Archive](https://snaps.qubelabs.io/celestia/) | - | | ||
| | QubeLabs | - | - | |
|
🚀 Preview Deployment Your preview is ready: https://celestiaorg.github.io/docs-preview/pr-2430/ |
fix lint errs