Skip to content

fix: resolve SQLite unique constraint crash in Work Profiles #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domedav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve SQLite unique constraint crash in Work Profiles #2504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions app/src/main/java/com/celzero/bravedns/database/ProxyApplicationMappingDAO.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import androidx.room.Insert
import androidx.room.OnConflictStrategy
import androidx.room.Query
import androidx.room.Update
import androidx.room.Transaction

@Dao
interface ProxyApplicationMappingDAO {
Expand Down Expand Up @@ -101,6 +102,23 @@ interface ProxyApplicationMappingDAO {
@Query("update ProxyApplicationMapping set uid = :uid where packageName = :packageName")
fun updateUidForApp(uid: Int, packageName: String)

@Query("update ProxyApplicationMapping set uid = :newUid where uid = :oldUid")
fun tombstoneApp(oldUid: Int, newUid: Int)
@Transaction
fun tombstoneApp(oldUid: Int, newUid: Int) {
// Only apply the logic bellow, if the uid is from a work profile
if (newUid >= 1_000_000) {
// If a record with the 'newUid' already exists, delete it first
// This prevents an application crash: database constraint
deleteMappingByUid(newUid)
}

// Now that the slot is empty, move the 'oldUid' records to 'newUid'
updateUidByOldUid(oldUid, newUid)
}

@Query("delete from ProxyApplicationMapping where uid = :uid")
fun deleteMappingByUid(uid: Int)

// 'ignore' provides an extra layer of safety
@Query("update or ignore ProxyApplicationMapping set uid = :newUid where uid = :oldUid")
fun updateUidByOldUid(oldUid: Int, newUid: Int)
}
Loading