This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Refactor resource util to match specs.#485
Merged
mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom May 28, 2019
Merged
Refactor resource util to match specs.#485mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom
mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 95.25% 95.27% +0.02%
==========================================
Files 147 148 +1
Lines 10470 10494 +24
Branches 739 734 -5
==========================================
+ Hits 9973 9998 +25
+ Misses 497 496 -1
Continue to review full report at Codecov.
|
songy23
reviewed
Apr 12, 2019
| Object.keys(mappings).forEach((key) => { | ||
| if (autoDetectedResource.labels[mappings[key]]) { | ||
| if (mappings[key] === resource.AWS_REGION_KEY) { | ||
| if (mappings[key] === CLOUD_RESOURCE.REGION_KEY) { |
Contributor
There was a problem hiding this comment.
You also need to check if the CloudProvider is AWS.
Member
Author
There was a problem hiding this comment.
Done, checking type is AWS_EC2_INSTANCE and key is REGION_KEY before adding aws: prefix. Sorry for the late response.
mayurkale22
force-pushed
the
newresource
branch
2 times, most recently
from
cb9055b to
2a99262
Compare
draffensperger
approved these changes
May 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454
Specs: census-instrumentation/opencensus-specs#235