Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Update dependency @types/nock to v10#553

Merged
mayurkale22 merged 2 commits intomasterfrom
renovate/nock-10.x
Jun 3, 2019
Merged

Update dependency @types/nock to v10#553
mayurkale22 merged 2 commits intomasterfrom
renovate/nock-10.x

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 24, 2019

This PR contains the following updates:

Package Type Update Change References
@​types/nock devDependencies major ^9.1.3 -> ^10.0.0 source

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented May 24, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@codecov-io
Copy link

Codecov Report

Merging #553 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage    95.3%   95.22%   -0.09%     
==========================================
  Files         147      147              
  Lines       10596    10273     -323     
  Branches      735      733       -2     
==========================================
- Hits        10099     9782     -317     
+ Misses        497      491       -6
Impacted Files Coverage Δ
src/common-utils.ts 75% <0%> (-20.24%) ⬇️
test/test-stackdriver-monitoring-utils.ts 93.18% <0%> (-6.82%) ⬇️
test/test-stackdriver-cloudtrace.ts 92.59% <0%> (-6.6%) ⬇️
src/http-stats.ts 100% <0%> (ø) ⬆️
test/test-jaeger-format.ts 96.15% <0%> (+1.23%) ⬆️
src/stackdriver-monitoring.ts 79.72% <0%> (+2.7%) ⬆️
src/zpages-frontend/latency-bucket-boundaries.ts 73.23% <0%> (+2.81%) ⬆️
test/nocks.ts 65.85% <0%> (+4.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2951f96...e93b4b7. Read the comment docs.

@mayurkale22
Copy link
Member

@draffensperger Please review, I have edited the renovate PR to fix the build failure.

test/nocks.ts:129:40 - error TS2345: Argument of type '(() => string) | undefined' is not assignable to parameter of type 'string | POJO'.
  Type 'undefined' is not assignable to type 'string | POJO'.

129     scope = interceptor.replyWithError(reply);

@mayurkale22 mayurkale22 merged commit 338ed3a into master Jun 3, 2019
@mayurkale22 mayurkale22 deleted the renovate/nock-10.x branch June 3, 2019 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants