Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

feat(nodejs-base): do not hook require when not necessary#585

Merged
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
hekike:feat/trace-base-no-hhok
Jul 3, 2019
Merged

feat(nodejs-base): do not hook require when not necessary#585
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
hekike:feat/trace-base-no-hhok

Conversation

@hekike
Copy link
Contributor

@hekike hekike commented Jul 2, 2019

require-in-the-module frames pollute CPU Profiles, also performance impact is not clear.
Do not enable when not necessary.

Screen Shot 2019-07-02 at 1 56 15 PM

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR!

@mayurkale22 mayurkale22 merged commit 69dddde into census-instrumentation:master Jul 3, 2019
@hekike hekike deleted the feat/trace-base-no-hhok branch July 3, 2019 23:24
@mayurkale22 mayurkale22 added this to the Release 0.0.15 milestone Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants