This repository was archived by the owner on Oct 3, 2023. It is now read-only.
chore(stackdriver): upgrade google-auth-library, drop node8#887
Merged
aabmass merged 1 commit intocensus-instrumentation:masterfrom Feb 16, 2021
Merged
Conversation
aabmass
changed the title
aabmass
force-pushed
the
upgrade-auth-library
branch
from
4c9bf3a to
236712c
Compare
aabmass
changed the title
aabmass
force-pushed
the
upgrade-auth-library
branch
from
236712c to
c8791de
Compare
aabmass
changed the title
aabmass
force-pushed
the
upgrade-auth-library
branch
5 times, most recently
from
5623d5d to
4a89df4
Compare
aabmass
requested review from
draffensperger,
hekike and
mayurkale22
as code owners
jsuereth
approved these changes
Feb 16, 2021
packages/opencensus-exporter-stackdriver/test/test-stackdriver-cloudtrace.ts
Show resolved
Hide resolved
punya
approved these changes
Feb 16, 2021
| filters: *release_tags | ||
| matrix: | ||
| parameters: | ||
| node_version: [10, 11, 12] |
There was a problem hiding this comment.
Not related to this PR, but in future we should consider not adding support for new unstable (odd-numbered) versions of NodeJS.
Member
Author
There was a problem hiding this comment.
Should we just leave these versions and not add any?
aabmass
force-pushed
the
upgrade-auth-library
branch
from
4a89df4 to
582d93b
Compare
BREAKING CHANGE: major version upgrade google-auth-library BREAKING CHANGE: dropping support node8 for security fix
aabmass
force-pushed
the
upgrade-auth-library
branch
from
582d93b to
059bb2c
Compare
This was referenced Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: major version upgrade google-auth-library
BREAKING CHANGE: dropping support node8 for security fix
Partial fix for #864
npm audit fix, no longer any security issues.npm run fixto re-format code with upgrade gts