Fix gosec errors and enable gosec linter#59
Merged
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
Bot
added
dco-signoff: yes
maelvls
reviewed
May 13, 2024
maelvls
reviewed
May 13, 2024
maelvls
previously requested changes
May 13, 2024
maelvls
left a comment
maelvls
left a comment
Member
There was a problem hiding this comment.
Mixing comments and logic makes it hard to read the logic (at least to me). In some places, you went with line comments, such as:
// #nosec G204
cmd := exec.Command(os.Args[0], "-test.run="+t.Name())But in other places, you went with inline comments that either make it hard to read logic or hides it to the far right of text editors
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
inteon
dismissed
maelvls’s stale review
The PR description was updated with the reason for this comment weirdness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked all found issues and applied fixes/ #nosec statements.
Now that all issues are fixed, I removed the gosec linter from the ignored section so future issues will be detected.
NOTE FOR REVIEWER:
Use
make verify-golangci-lintto quickly run golangci-lint.I had to mix the comments with the code to make sure the nosec comments were picked up by gosec (see securego/gosec#278 (comment)).