This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Merged
Conversation
BREAKING CHANGES: - Use `hashchange` instead of `pushState` for better browser support - Remove `updateUrl` option, since URL will always update - Fixed focus state approach - Pass Node or Number, not ID string, into `animateScroll` method - Remove `escapeCharacters` from public API - If scrolling to top with `#`, add an ID to the body and scroll that way - Only look for fixed header if a selector for one is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
hashchangeinstead ofpushStatefor better browser supportupdateUrloption, since URL will always updateanimateScrollmethodescapeCharactersfrom public API#, add an ID to the body and scroll that way