feat: add DBParameterGroupName to rds#23
Open
Ancordss wants to merge 4 commits intocfn-modules:masterfrom
Open
feat: add DBParameterGroupName to rds#23Ancordss wants to merge 4 commits intocfn-modules:masterfrom
Ancordss wants to merge 4 commits intocfn-modules:masterfrom
Conversation
Ancordss
changed the title
Ancordss
changed the title
Contributor
|
Hi @Ancordss Thanks for this PR! Could you merge master to include my latest changes to get the acceptance tests back to working? |
Author
|
HI @michaelwittig Done!! |
Contributor
|
@Ancordss Thanks for adding the test as well. Much appreciated. I just wait for the test results before I merge. |
michaelwittig
requested changes
Jun 28, 2024
Contributor
|
test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to add a missing parameter to the module
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.