Skip to content

Force personMap Reactivity #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lechristianfillon wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −5
Open

Force personMap Reactivity #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a635efe
Force personMap Reactivity
lechristianfillon Feb 27, 2026
42d2c06
Merge branch 'main' into personMapReactivityIssue
lechristianfillon Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/modals/EditPersonModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ export default {
}
},

emits: ['cancel'],
// eslint-disable-next-line vue/no-unused-emit-declarations
emits: ['cancel', 'confirm', 'confirm-invite', 'invite'],

data() {
return {
Expand Down
16 changes: 12 additions & 4 deletions src/store/modules/people.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ const initialState = {
personTimeSpentTotal: 0,
personDayOff: {},
daysOff: [],
dayOffMap: {}
dayOffMap: {},
personMapVersion: 0
}

const state = {
Expand All @@ -182,7 +183,11 @@ const getters = {
cache.people.filter(person => person.active && !person.is_bot),
displayedPeople: state => state.displayedPeople,
peopleIndex: state => cache.peopleIndex,
personMap: state => cache.personMap,
personMap: state => {
// Access personMapVersion to trigger reactivity when the map changes.
state.personMapVersion // eslint-disable-line no-unused-expressions
return cache.personMap
},
isPeopleLoading: state => state.isPeopleLoading,
isPeopleLoadingError: state => state.isPeopleLoadingError,
peopleSearchQueries: state => state.peopleSearchQueries,
Expand Down Expand Up @@ -267,8 +272,8 @@ const actions = {
},

async newPersonAndInvite({ commit }, data) {
let person = await peopleApi.createPerson(data)
person = await peopleApi.invitePerson(person)
const person = await peopleApi.createPerson(data)
await peopleApi.invitePerson(person)
commit(EDIT_PEOPLE_END, person)
return person
},
Expand Down Expand Up @@ -614,6 +619,7 @@ const mutations = {
cache.people.forEach(person => {
cache.personMap.set(person.id, person)
})
state.personMapVersion++
state.displayedPeople = cache.people
cache.peopleIndex = buildPeopleIndex(cache.people)

Expand All @@ -630,6 +636,7 @@ const mutations = {
}
cache.personMap.delete(person.id)
}
state.personMapVersion++
cache.peopleIndex = buildPeopleIndex(cache.people)
if (state.peopleSearchText) {
const keywords = getKeyWords(state.peopleSearchText)
Expand All @@ -651,6 +658,7 @@ const mutations = {
cache.people.push(person)
}
cache.personMap.set(person.id, person)
state.personMapVersion++
cache.people = sortPeople(cache.people)
cache.peopleIndex = buildPeopleIndex(cache.people)
if (state.peopleSearchText) {
Expand Down