-
Notifications
You must be signed in to change notification settings - Fork 79
Add chainguard-install action. #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Experimental action for installing Chainguard packages on GitHub Actions.
|
|
||
| echo "::endgroup::" | ||
|
|
||
| # ============================================================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have those steps here in different workflow steps? and not in the huge script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm iffy on this - I don't see a strong reason to do it. Having the top level variables as one script it much easier than needing to plumb these through to each step. We group these ourselves, so the end user UX will end up looking similar anyway. 🤷
We can refactor this later if we need do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
|
and for the bootstrap should we set the action to use a base container image? |
|
Switched to using wolfi-base + cosign to bootstrap! |
cpanato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Experimental action for installing Chainguard packages on GitHub Actions.
The biggest challenge here is bootstrapping the initial APK. This is mostly statically configured today (open to other suggestions for how to bootstrap this!).