shellcheck_run_steps.py: read arch from pkg YAML#17
Merged
AbduAzim424 merged 4 commits intochainguard-dev:mainfrom Aug 6, 2025
Merged
shellcheck_run_steps.py: read arch from pkg YAML#17AbduAzim424 merged 4 commits intochainguard-dev:mainfrom
AbduAzim424 merged 4 commits intochainguard-dev:mainfrom
Conversation
…ile portion to prevent architecture specific packages to fail Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
c8e17ed to
cdaf3eb
Compare
dannf
requested changes
Aug 5, 2025
Contributor
dannf
left a comment
There was a problem hiding this comment.
We can just look at the melange YAML and parse target-architectures. if that field exists, use the first arch it lists. If it doesn't exist, maybe just use x86_64.
682d899 to
825c568
Compare
dannf
requested changes
Aug 5, 2025
Contributor
dannf
left a comment
There was a problem hiding this comment.
thanks! I like this better. A few more comments inline.
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
825c568 to
b10a5b1
Compare
dannf
reviewed
Aug 5, 2025
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
dannf
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read architecture from the package definition or default to
x86_64to prevent architecture specific packages to fail.Example:
raspberry-pi-utils.yamlpackage failed to pass the lint phase as we were usingos.uname().machineof the CI environment for all the packages.