swb: a few fixes (module namespace, Debugger)#2364
Merged
Conversation
added 3 commits
January 11, 2017 18:23
OP_StModuleSlot was changing slot without write barrier. Annotate all related code. (Credit to Lei for finding it is module namespace related.)
This reverts commit c49e4af. It should now work after Oguz removed wchar_t redef from PAL.
Found under stress unit testing. Debugger::m_context was not pinned and could be GC collected when not in use.
leirocks
approved these changes
Jan 12, 2017
| case Js::OpCode::StModuleSlot: | ||
| { | ||
| Js::Var* moduleExportVarArrayAddr = Js::JavascriptOperators::OP_GetModuleExportSlotArrayAddress(slotId1, slotId2, m_func->GetScriptContextInfo()); | ||
| Field(Js::Var)* moduleExportVarArrayAddr = Js::JavascriptOperators::OP_GetModuleExportSlotArrayAddress(slotId1, slotId2, m_func->GetScriptContextInfo()); |
Contributor
There was a problem hiding this comment.
why do you need this change?
Contributor
There was a problem hiding this comment.
ah, I see, you changed the return type. however I think we should avoid using Field() in backend code. may be create a version of OP_GetModuleExportSlotArrayAddress_Backend, or force cast to Js::Var*
Author
There was a problem hiding this comment.
Here it is a pointer use only, I hate cast if unnecessary...
Collaborator
|
Debugger change to pin/unpin looks good to me |
obastemur
reviewed
Jan 12, 2017
| double | ||
| __cdecl | ||
| double | ||
| __cdecl |
Collaborator
There was a problem hiding this comment.
nit: some empty spaces here and below
Author
There was a problem hiding this comment.
Yes, I simply reverted to previous version. It contains spaces but would be identical and easier to merge back to master.
Author
|
@leirocks @agarwal-sandeep @obastemur Thanks for CR! |
jianchun
pushed a commit
that referenced
this pull request
Jan 12, 2017
Merge pull request #2364 from jianchun:swbmodule ### swb: fix module namespace annotation OP_StModuleSlot was changing slot without write barrier. Annotate all related code. (Credit to Lei for finding it is module namespace related.) ### Revert "fix a pal build issue on my machine" This reverts commit c49e4af. It should now work after Oguz removed wchar_t redef from PAL. ### pin Debugger::m_context Found under stress unit testing. Debugger::m_context was not pinned and could be GC collected when not in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swb: fix module namespace annotation
OP_StModuleSlot was changing slot without write barrier. Annotate all
related code.
(Credit to Lei for finding it is module namespace related.)
Revert "fix a pal build issue on my machine"
This reverts commit c49e4af.
It should now work after Oguz removed wchar_t redef from PAL.
pin Debugger::m_context
Found under stress unit testing. Debugger::m_context was not pinned
and could be GC collected when not in use.