Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pylint
tests/test_tasks/test_task_utlities/test_redis/test_redis_list.py|64 col 27| W0621: Redefining name 'redis_list' from outer scope (line 8) (redefined-outer-name)
tests/test_tasks/test_task_utlities/test_redis/test_redis_list.py|70 col 4| C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
tests/test_tasks/test_task_utlities/test_key_handler/test_github_api_key_handler.py
Show resolved
Hide resolved
|
@JohnStrunk / @MoralCode : The end to end test is timing out, but not "failing" in the ordinary sense. . I am wonder if the timeout is a parameter we need to set higher? |
This isnt a timeout issue, the code in this PR made a change that broke something. The stacktrace above the timeout error points to: This was also flagged by a bot that is installed https://github.com/chaoss/augur/pull/3218/files#r2191362618 (among many other warnings) |
MoralCode
left a comment
There was a problem hiding this comment.
I'd recommend holding off until the various warnings and errors caught by the automation tools (the bot and the E2E CI job) are resolved
|
|
||
| self.id = getpid() | ||
| self.stdin: PubSub = conn.pubsub(ignore_subscribe_messages = True) | ||
| self.stdin: PubSub = self.conn.pubsub(ignore_subscribe_messages = True) |
There was a problem hiding this comment.
I think this needs to be fixed.
Update to address error message in end to end build. Signed-off-by: Sean P. Goggins <outdoors@acm.org>
Description
This PR fixes #
#3047
Signed commits