use check_output for git log fetching so that it can fail more easily#3232
Merged
sgoggins merged 1 commit intochaoss:mainfrom Jul 18, 2025
Merged
use check_output for git log fetching so that it can fail more easily#3232sgoggins merged 1 commit intochaoss:mainfrom
sgoggins merged 1 commit intochaoss:mainfrom
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
sgoggins
approved these changes
Jul 18, 2025
Member
sgoggins
left a comment
sgoggins
left a comment
There was a problem hiding this comment.
@MoralCode : Does this possibly fix the facade stall issue @cdolfi identied on your instance?
Contributor
Author
Possibly, but I was hoping that others could help test and confirm that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address the problem of analyze_commits_in_parallel hanging as mentioned in #3228
It does so by using the same
check_outputmethod of running git shell commands as can be seen in the rest of theanalyze_commitfunction. This method of running commands has a lot more error handling capabilities thanPopen(which was used before) and can thus fail on conditions such as a nonzero exit code, allowing the facade task to fail and therefore allowing other tasks to run in that time (while allowing us to go in and diagnose the failure)Signed commits