scheduling: refactor send_messages to de-duplicate code path#3271
Merged
sgoggins merged 1 commit intochaoss:mainfrom Sep 16, 2025
Merged
scheduling: refactor send_messages to de-duplicate code path#3271sgoggins merged 1 commit intochaoss:mainfrom
sgoggins merged 1 commit intochaoss:mainfrom
Conversation
MoralCode
changed the title
MoralCode
force-pushed
the
collection_util-duplicate-code
branch
from
8825895 to
8dfe1f7
Compare
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
collection_util-duplicate-code
branch
from
8dfe1f7 to
33debfd
Compare
Contributor
Author
|
interestingly, this change was discovered when I asked gemini for some help tracking down the facade changes. It made a code change and, when describing the changes, said "The same logic is applied to GitLab phases." - prompting me to go see what the differences were between the two implementations before realizing they could be deduplicated |
MoralCode
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in looking for the facade scheduling issues, I noticed a couple structural (not functional) issues that arent directly going to solve the core problem but just help to clean up the code so its more readable when trying to debug the facade issues
This essentially moves the actual "meat" of this function to below the if-else chain and extracts a couple new variables to abstract the differences between the two implementations (i.e. changing which list of phases gets used, and also printing the correct platform name in log messages)
Signed commits