Skip to content

docker compose: Make it crystal clear that all the GitHub/GitLab user/keys must be set#3300

Merged
sgoggins merged 1 commit intochaoss:mainfrom
giordano:mg/do-not-remove-env-variables
Oct 9, 2025
Merged

docker compose: Make it crystal clear that all the GitHub/GitLab user/keys must be set#3300
sgoggins merged 1 commit intochaoss:mainfrom
giordano:mg/do-not-remove-env-variables

Conversation

@giordano
Copy link
Contributor

@giordano giordano commented Oct 6, 2025

The non-interactive Docker compose workflow requires all the variables AUGUR_GIT{LA,HU}B_{USERNAME,API_KEY} to be set even if they are going to be unused, otherwise you get stuck waiting for the prompt

You entered a blank line, are you sure?

Signed commits

  • Yes, I signed my commits.

…/keys must be set

The non-interactive Docker compose workflow requires all the variables
`AUGUR_GIT{LA,HU}B_{USERNAME,API_KEY}` to be set even if they are going to be
unused, otherwise you get stuck waiting for [the prompt](https://github.com/chaoss/augur/blob/b0bb3b80402ee5fcd84bec7334e58a41f9f5ec8a/scripts/install/config.sh#L18-L29)
```
You entered a blank line, are you sure?
```

Signed-off-by: Mosè Giordano <m.giordano@ucl.ac.uk>
@giordano giordano requested a review from sgoggins as a code owner October 6, 2025 21:02
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins requested a review from MoralCode October 8, 2025 18:27
@sgoggins sgoggins merged commit e780526 into chaoss:main Oct 9, 2025
10 checks passed
@giordano giordano deleted the mg/do-not-remove-env-variables branch October 9, 2025 14:04
Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the docs change here - had some small feedback on it but it otherwise looks okay.

Ultimately I think this is something that we should/could also resolve via a code change, potentially as part of improvements to how keys are added/specified, config updates, etc.

Is there an issue filed for this as well so we can fix the underlying behavior?

.. warning::

Don't forget to provide your external database credentials in a file called ``.env`` file. Make sure the following environment variables are specified.
Don't forget to provide your external database credentials in a file called ``.env`` file. Make sure all the following environment variables are specified, keep placeholder values if you don't need some of them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to explain why the placeholders should be kept? (i.e. it will cause things not to start up if one is left unspecified?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants