Centralize Version Management via metadata.py for Docker and CI/CD#3305
Centralize Version Management via metadata.py for Docker and CI/CD#3305sgoggins merged 3 commits intochaoss:mainfrom
Conversation
5c7c073 to
4be5ad2
Compare
MoralCode
left a comment
There was a problem hiding this comment.
Great start! Could you also include an update to the README to remove the (at least two) references to the specific current version number (and potentially link to the /releases/latest pageof the github releases tab where needed instead)?
Also if i remember correctly, there was a change discussed on slack to update the documentation about the release process as well.
Overall this looks like it definitely helps reduce the number of things to change each release though!
scripts/ci/get_version.py
Outdated
There was a problem hiding this comment.
is this file used anywhere?
There was a problem hiding this comment.
I think that is answered in the previous comment, which also explains the purpose of that line.
There was a problem hiding this comment.
This file contains a lot of formatting changes that arent directly related to the purpose of this PR.
Could you be using any particular tools that are attempting to reformat things?
There was a problem hiding this comment.
Looking at the doc file, it does appear there is probably some IDE doing automatic reformatting.
|
@skools-here can you rebase/squash commits and make sure all commits are signed-off? |
40f685d to
8f7d3a4
Compare
|
@skools-here it seems like your rebase accidentally pulled in an extra commit from main thats unrelated |
992b386 to
6a193e0
Compare
|
yes I have fixed it now I don't how that happened though. |
it looks like you just created a new commit that un-does the changes, which is going to cause git to effectively roll those changes back when this merges. I wish there was a better tool than git that didn't make it so easy to do this kind of thing. Could you rebase your PR on top of main (again) but only include the three commits you intend to keep? If it helps, I tend to think of operations like this more like a "hard reset your branch to main and then cherry pick the commits you want". Also happy to talk on the CHAOSS slack if you want more specific/detailed guidance! |
6a193e0 to
eb04e21
Compare
|
@MoralCode Ah, got it — I see what happened now 😅 I’ll rebase my branch onto main and cherry-pick only the three commits related to centralized version management. Thanks for catching that! |
|
almost there! To avoid the need for that final merge commit from main into this branch, you'll likely need to update your fork's |
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
bff20af to
fb88a92
Compare
|
@MoralCode Thanks a lot for helping me out I was really wondering how to resolve this problem ! |
sgoggins
left a comment
There was a problem hiding this comment.
LGTM. Not loving the random formatting in Restructured Text, but the CI is working now ... :)
|
@sgoggins ngl even I don't know what's that formatting problem :(( . ig it's my editor problem. But hopefully this pr fixed that version management issue ! |
Description
3)pyproject.toml already reads from metadata.py; no changes needed there.
This PR fixes #3294
Notes for Reviewers
Signed commits