Skip to content

Centralize Version Management via metadata.py for Docker and CI/CD#3305

Merged
sgoggins merged 3 commits intochaoss:mainfrom
skools-here:centralize-version-management
Oct 16, 2025
Merged

Centralize Version Management via metadata.py for Docker and CI/CD#3305
sgoggins merged 3 commits intochaoss:mainfrom
skools-here:centralize-version-management

Conversation

@skools-here
Copy link
Contributor

Description

  1. metadata.py now serves as the single source of version (version)
  2. Updated all Dockerfiles to dynamically read the version from metadata.py during CI/CD builds.
    3)pyproject.toml already reads from metadata.py; no changes needed there.

This PR fixes #3294

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@skools-here skools-here requested a review from sgoggins as a code owner October 11, 2025 12:30
@skools-here skools-here force-pushed the centralize-version-management branch from 5c7c073 to 4be5ad2 Compare October 11, 2025 12:31
sgoggins
sgoggins previously approved these changes Oct 13, 2025
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Could you also include an update to the README to remove the (at least two) references to the specific current version number (and potentially link to the /releases/latest pageof the github releases tab where needed instead)?

Also if i remember correctly, there was a change discussed on slack to update the documentation about the release process as well.

Overall this looks like it definitely helps reduce the number of things to change each release though!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file used anywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is answered in the previous comment, which also explains the purpose of that line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains a lot of formatting changes that arent directly related to the purpose of this PR.

Could you be using any particular tools that are attempting to reformat things?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the doc file, it does appear there is probably some IDE doing automatic reformatting.

@MoralCode
Copy link
Contributor

@skools-here can you rebase/squash commits and make sure all commits are signed-off?

@skools-here skools-here force-pushed the centralize-version-management branch 4 times, most recently from 40f685d to 8f7d3a4 Compare October 15, 2025 18:14
@MoralCode
Copy link
Contributor

@skools-here it seems like your rebase accidentally pulled in an extra commit from main thats unrelated

@skools-here skools-here force-pushed the centralize-version-management branch from 992b386 to 6a193e0 Compare October 15, 2025 18:20
@skools-here
Copy link
Contributor Author

yes I have fixed it now I don't how that happened though.

@MoralCode
Copy link
Contributor

yes I have fixed it now I don't how that happened though.

it looks like you just created a new commit that un-does the changes, which is going to cause git to effectively roll those changes back when this merges.

I wish there was a better tool than git that didn't make it so easy to do this kind of thing.

Could you rebase your PR on top of main (again) but only include the three commits you intend to keep? If it helps, I tend to think of operations like this more like a "hard reset your branch to main and then cherry pick the commits you want". Also happy to talk on the CHAOSS slack if you want more specific/detailed guidance!

@skools-here skools-here force-pushed the centralize-version-management branch from 6a193e0 to eb04e21 Compare October 15, 2025 20:52
@skools-here
Copy link
Contributor Author

@MoralCode Ah, got it — I see what happened now 😅 I’ll rebase my branch onto main and cherry-pick only the three commits related to centralized version management. Thanks for catching that!
I’ll clean it up and push again soon .If I run into any hiccups, I’ll reach out to you on CHAOSS Slack for a help. I also think that there can be better tools than git.

@MoralCode
Copy link
Contributor

almost there! To avoid the need for that final merge commit from main into this branch, you'll likely need to update your fork's main branch so it matches this repo (if you visit your fork in the github UI it should give you a "sync fork" button). Then if you rebase it should set this branch up to be based on the latest version of main, not just the latest at the time you made your fork

Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
@skools-here skools-here force-pushed the centralize-version-management branch from bff20af to fb88a92 Compare October 15, 2025 23:12
@skools-here
Copy link
Contributor Author

@MoralCode Thanks a lot for helping me out I was really wondering how to resolve this problem !

Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoralCode MoralCode added security Related to keeping Augur secure ready Items tested and seeking additional approvals or a merge. Usually for items under active development and removed security Related to keeping Augur secure labels Oct 16, 2025
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not loving the random formatting in Restructured Text, but the CI is working now ... :)

@sgoggins sgoggins merged commit c3d8c4c into chaoss:main Oct 16, 2025
10 checks passed
@skools-here
Copy link
Contributor Author

@sgoggins ngl even I don't know what's that formatting problem :(( . ig it's my editor problem. But hopefully this pr fixed that version management issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Items tested and seeking additional approvals or a merge. Usually for items under active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

centralize repo version locations

3 participants