Log facade messages based on the type requested#3309
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
sgoggins
left a comment
sgoggins
left a comment
There was a problem hiding this comment.
I could be missing some "automatic feature", but if I'm not we need to address the primary case, which is ALL CAPS in the settings.
| log_options = ('Error','Quiet','Info','Verbose','Debug') | ||
| self.logger.info(f"* {status}\n") | ||
| logmsg = f"* {status}\n" | ||
| if level == "Error": |
There was a problem hiding this comment.
The message level is usually set in all caps like , DEBUG or ERROR .. does this logging checker do anything to account for differences in case? I think it needs to ...
There was a problem hiding this comment.
that is added/managed by the logging package (i.e. when self.logger.<whatevr>() is called)
All we need to worry about here is the level parameter being passed to this function. All the existing calls to this logging helper that I see use Camel case and the existing check for whether Debug mode is requested does not account for casing, so i think its fine.
I will also be likely entirely rewriting all this logic if/when i fix #3308
MoralCode
added
the
ready
2 participants
Description
This PR fixes #3307
Notes for Reviewers
Signed commits