Skip to content

Fix variables issue in #3183#3332

Merged
sgoggins merged 3 commits intochaoss:mainfrom
PredictiveManish:fix-variables-issue
Oct 30, 2025
Merged

Fix variables issue in #3183#3332
sgoggins merged 3 commits intochaoss:mainfrom
PredictiveManish:fix-variables-issue

Conversation

@PredictiveManish
Copy link
Contributor

Description
This PR resolves the warnings given in changes in #3183. Removes the unused import sphinx_rtd_theme and import variables __copyright__, __release__, __version__ correctly from metadata.py into conf.py as suggested by reviewbot.

This PR fixes small import issues.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth looping in the author of the prior PR that this update is for @JohnStrunk.

Overall i dont really have much opinion on this other than these diffs seem reasonably small - will probably defer explicit approval to other maintainers who have more experience to better evaluate whether these changes are helpful

@PredictiveManish
Copy link
Contributor Author

Might also be worth looping in the author of the prior PR that this update is for @JohnStrunk.

Overall i dont really have much opinion on this other than these diffs seem reasonably small - will probably defer explicit approval to other maintainers who have more experience to better evaluate whether these changes are helpful

Yes, this issue is not that much big just a small warning! Main issue is the other part of unable to importing properly! it's just a solution for the warning!

Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. I'm largely trusting that the readthedocs build worker is a good indicator of whether this works though.

@MoralCode MoralCode added the ready Items tested and seeking additional approvals or a merge. Usually for items under active development label Oct 30, 2025
@MoralCode MoralCode added this to the v0.91.0 Release milestone Oct 30, 2025
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins merged commit 56b4ee0 into chaoss:main Oct 30, 2025
10 checks passed
@PredictiveManish PredictiveManish deleted the fix-variables-issue branch November 9, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Items tested and seeking additional approvals or a merge. Usually for items under active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants