Conversation
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
MoralCode
left a comment
There was a problem hiding this comment.
Might also be worth looping in the author of the prior PR that this update is for @JohnStrunk.
Overall i dont really have much opinion on this other than these diffs seem reasonably small - will probably defer explicit approval to other maintainers who have more experience to better evaluate whether these changes are helpful
Yes, this issue is not that much big just a small warning! Main issue is the other part of unable to importing properly! it's just a solution for the warning! |
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
MoralCode
left a comment
There was a problem hiding this comment.
seems good to me. I'm largely trusting that the readthedocs build worker is a good indicator of whether this works though.
Description
This PR resolves the warnings given in changes in #3183. Removes the unused import
sphinx_rtd_themeand import variables__copyright__, __release__, __version__correctly frommetadata.pyintoconf.pyas suggested by reviewbot.This PR fixes small import issues.
Signed commits