Deduplicate/lib get_section - and some other config improvements#3357
Merged
Deduplicate/lib get_section - and some other config improvements#3357
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…ters of varying types Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…m an existing config object Signed-off-by: Adrian Edwards <adredwar@redhat.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MoralCode
added
the
config
MoralCode
force-pushed
the
deduplicate/lib-get_section
branch
from
190bd00 to
0310d32
Compare
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
deduplicate/lib-get_section
branch
from
0310d32 to
6e47e06
Compare
Contributor
Author
|
Runs on my machine. Found the missing import causing issues with the CI jobs |
MoralCode
added
the
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lib.pyhas a function calledget_sectionthat retrieves a value from the config database. This function duplicates functionality from theaugur.application.config.AugurConfigclass.It is currently causing issues with new installs. Users are seeing python
KeyErrorwhen trying to read config values that are newly added to the database, such asfacade_contributor_full_recollectthat was added in #3303.While this PR doesnt fix the
KeyError, it ensures that the config is not being read in multiple ways, allowing for a simpler implementation in #3356This PR migrates the remaining few uses of the old function over to the new implementation
Notes for Reviewers
Signed commits