Time scale only aligns single point

[benmccann]

We should align on the start of every major unit and put the minor ticks evenly between major units. Right now we only align a single major ticks and it looks really weird.

I have a fix for this on a branch locally. Screenshot of the current version and fixed version below.

There's one thing I need to figure out before I can send this PR, which is that I need to move generate to be a class member so that I can call getPixelForOffset and getLabelCapacity. However, that would just make Chart.Ticks.generators even more broken than it already is (#4599). I'm not sure there's any good way to make Chart.Ticks.generators work. I'd really love to remove it since I can't find anyone using it though that would technically be a breaking change.

Current

After Fix

[simonbrunel]

Why generate would have to call getPixelForOffset, which one using the lookup table, which one being fed with the generate output?

[andig]

We should align on the start of every major unit and put the minor ticks evenly between major units

I don't think its doing that: the "after" chart has inconsistent grid line spacing. There might be use cases for it but in general I find it really confusing.

[andig]

@etimberg here's an wip example using default time scale styling that highlights why I'm not a fan of the major ticks (unless they can be turned off):

Imho the major (year) ticks should show up identically. Imho that should be the default styling.