Start moving lecacy scale hooks to plugin#10631
Draft
LeeLenaleee wants to merge 1 commit intochartjs:masterfrom
Draft
Start moving lecacy scale hooks to plugin#10631LeeLenaleee wants to merge 1 commit intochartjs:masterfrom
LeeLenaleee wants to merge 1 commit intochartjs:masterfrom
Conversation
Member
|
Yeah, I had thought we could remove line 527 so that it only goes to plugins and avoids these option callbacks |
Member
|
@LeeLenaleee @kurkle do we still want this in v4? It's the last thing |
Collaborator
Author
|
Every time I look at the test i can't seem to make them work so stopped looking at it, will give it another look Monday evening see if a fresh look sees what I did wrong and otherwise we can either skip it or someone else has to fix the test |
Member
|
I'm thinking we should skip this and move it to v5 at this point. Thoughts @LeeLenaleee @kurkle @dangreen ? |
Collaborator
Author
|
Agree |
1 similar comment
Collaborator
|
Agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10155
TODO:
@etimberg you added the breaking change to it but in its current form its not breaking right since it still calls the hooks like it used to or do you want to have the
call(line 527) here also removed?Chart.js/src/core/core.scale.js
Lines 525 to 528 in f957aad