Require fog-aws vs. fog#377
Merged
Merged
Conversation
Fog started out as a monolithic project and is slowly being broken out into smaller libraries. Fog rolls up all of the individual libraries to provide the same behavior in a backwards compatible form. Since we're only interacting with AWS all we really need is fog-aws which depends on fog-core, fog-json, and fog-xml. Here's the positive results of this change: Gems we're no longer be depending on: Using inflecto 0.0.2 Using fog-brightbox 0.9.0 Using fog-ecloud 0.3.0 Using fog-local 0.2.1 Using fog-powerdns 0.1.1 Using fog-profitbricks 0.0.5 Using fog-radosgw 0.0.4 Using fog-riakcs 0.1.0 Using fog-sakuracloud 1.3.3 Using fog-serverlove 0.1.2 Using fog-softlayer 1.0.2 Using fog-storm_on_demand 0.1.1 Using fog-terremark 0.1.0 Using fog-vmfusion 0.1.0 Using fog-voxel 0.1.0 Using fog 1.29.0 Using fog-atmos 0.1.0 Using fission 0.5.0 Using CFPropertyList 2.3.2 Load time of the requires: fog: 0m1.758s fog-aws: 0m0.682s So we speed up our load time by a second and we remove 19 dependencies. Also since we're no longer depending directly on fog, we won't pin fog in a way that breaks people that use other knife cloud plugins as we've done in the past.
|
Change looks good to me. Getting this integrated would be great. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fog started out as a monolithic project and is slowly being broken out into smaller libraries. Fog rolls up all of the individual libraries to provide the same behavior in a backwards compatible form. Since we're only interacting with AWS all we really need is fog-aws which depends on fog-core, fog-json, and fog-xml. Here's the positive results of this change:
Gems we will no longer be depending on:
Using inflecto 0.0.2
Using fog-brightbox 0.9.0
Using fog-ecloud 0.3.0
Using fog-local 0.2.1
Using fog-powerdns 0.1.1
Using fog-profitbricks 0.0.5
Using fog-radosgw 0.0.4
Using fog-riakcs 0.1.0
Using fog-sakuracloud 1.3.3
Using fog-serverlove 0.1.2
Using fog-softlayer 1.0.2
Using fog-storm_on_demand 0.1.1
Using fog-terremark 0.1.0
Using fog-vmfusion 0.1.0
Using fog-voxel 0.1.0
Using fog 1.29.0
Using fog-atmos 0.1.0
Using fission 0.5.0
Using CFPropertyList 2.3.2
Load time of the requires:
fog: 0m1.758s
fog-aws: 0m0.682s
So we speed up our load time by a second and we remove 19 dependencies. Also since we're no longer depending directly on fog, we won't pin fog in a way that breaks people that use other knife cloud plugins as we've done in the past.