Skip to content

Added --json-for-attributes-file#400

Merged
NimishaS merged 2 commits into
chef:masterfrom
MsysTechnologiesllc:vj/add_option_json_attribute_file
Feb 3, 2016
Merged

Added --json-for-attributes-file#400
NimishaS merged 2 commits into
chef:masterfrom
MsysTechnologiesllc:vj/add_option_json_attribute_file

Conversation

@Vasu1105

Copy link
Copy Markdown

w.r.t #397 Added --json-for-attributes-file option and updated option names to first_boot_attributes to maintain uniquness through out all knife plugins for names.

…irst_boot_attributes to maintain uniquness through out all knife plugins for names
Comment thread lib/chef/knife/ec2_server_create.rb Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamedx , the option name is first_boot_attributes in chef. That's why we have renamed json_attributes to first_boot_attributes. Is it ok to merge this?

@adamedx

adamedx commented Feb 1, 2016

Copy link
Copy Markdown

So knife bootstrap has a --json-attributes argument and config -- since we inherit from the knife base class, why are we overriding it in the server create subcommand? Ideally this functionality isn't something we should have to implement at all since it seems like knife already contains an implementation.

@Vasu1105

Vasu1105 commented Feb 1, 2016

Copy link
Copy Markdown
Author

right @adamedx I will do the necessary changes.

NimishaS pushed a commit that referenced this pull request Feb 3, 2016
…ttribute_file

Added --json-for-attributes-file
@NimishaS NimishaS merged commit 69633c7 into chef:master Feb 3, 2016
@NimishaS NimishaS deleted the vj/add_option_json_attribute_file branch February 3, 2016 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants