feat: Improve peak shape options#4114
Merged
hamed-musallam merged 7 commits intomainfrom May 7, 2026
Merged
Conversation
Closed
hamed-musallam
force-pushed
the
improve-peak-shape-options
branch
from
8f880a1 to
ba5b4c2
Compare
Deploying nmrium with
|
| Latest commit: |
a68bc5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fece93ad.nmrium.pages.dev |
| Branch Preview URL: | https://improve-peak-shape-options.nmrium.pages.dev |
hamed-musallam
force-pushed
the
improve-peak-shape-options
branch
from
ba5b4c2 to
4a7e50f
Compare
tpoisseau
reviewed
May 6, 2026
Contributor
tpoisseau
left a comment
tpoisseau
left a comment
There was a problem hiding this comment.
Otherwise LGTM except this
CleanShot.2026-05-06.at.09.11.23.mp4
Is it normal we can optimize more than 9 times with peak intensity change ?
Contributor
You can upgrade theses packages. |
hamed-musallam
force-pushed
the
improve-peak-shape-options
branch
from
693b058 to
a68bc5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.