fix build error on header missing and new version of boost#715
Open
Gitspike wants to merge 1 commit intochenshuo:cpp17from
Open
fix build error on header missing and new version of boost#715Gitspike wants to merge 1 commit intochenshuo:cpp17from
Gitspike wants to merge 1 commit intochenshuo:cpp17from
Conversation
Open
这是什么意思? 请问具体应当如何操作？ |
|
这个问题不只是存在cpp17分支 |
chenshuo
reviewed
Dec 23, 2025
|
|
||
| // Author: Shuo Chen (chenshuo at chenshuo dot com) | ||
|
|
||
| #include <cstddef> |
Owner
There was a problem hiding this comment.
Please remove this line, it has been fixed in e9b1bb3.
chenshuo
reviewed
Dec 23, 2025
|
|
||
| #include <cstddef> | ||
| #include <muduo/net/InetAddress.h> | ||
|
|
Owner
There was a problem hiding this comment.
Keep this blank line, follow:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include header file in muduo/net/InetAddress.cc
add Ctor for new version of boost in examples/ace/ttcp/ttcp_asio_async.cc