changed CGrectGetMaxX to CGRectGetMaxY, to get actual header height, not... #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice catch, thanks! |
chiahsien
added a commit
that referenced
this pull request
Nov 22, 2014
changed CGrectGetMaxX to CGRectGetMaxY, to get actual header height, not...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was a bug when using the .swift version - the layout cells would appear far down from the header if the header cell height was set to greater than zero. i determined it was because CGRectGetMaxX was being used instead of the 'Y' counterpart. The Obj-C version uses CGRectGetMaxY as well. This solved the issue on my development app.
Thanks for creating a .swift version! :)