fix(src): Close connections to API clients when shutting down#219
Merged
christgau merged 2 commits intochristgau:masterfrom Dec 26, 2024
Merged
fix(src): Close connections to API clients when shutting down#219christgau merged 2 commits intochristgau:masterfrom
christgau merged 2 commits intochristgau:masterfrom
Conversation
This effectively re-implements asyncio.Server::close_clients which is only available in python3.13. In python3.12 asyncio.Server::wait_closed will hang unless these sockets are closed: python/cpython#104344 Co-authored-by: Steffen Christgau <mail@s14u.de>
christgau
force-pushed
the
wait_closed
branch
from
772a824 to
f1c76ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively re-implements
asyncio.Server::close_clientswhich is only available in python3.13.In python3.12
asyncio.Server::wait_closedwill hang unless these sockets are closed: python/cpython#104344