Add track_caller to non-deprecated functions#1774
Conversation
svix-jplatte
temporarily deployed
to
Coverage
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 35 35
Lines 13769 13769
=======================================
Hits 12374 12374
Misses 1395 1395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| let mut result = String::with_capacity(32); | ||
| write_rfc2822(&mut result, self.overflowing_naive_local(), self.offset.fix()) | ||
| .expect("writing rfc2822 datetime to string should never fail"); | ||
| .expect("date cannot be represented by RFC 2822"); |
There was a problem hiding this comment.
I don't actually know whether the Panics documentation on this function or the previous expect message is correct - just implemented what seemed more likely to be correct.
|
Also, happy to shorten the diff by removing the attribute again on all |
Yes, that might be nice. Also, if you'd like this released, add a version bump commit? |
… that can panic because of invalid user input.
svix-jplatte
force-pushed
the
jplatte/track_caller
branch
from
512600e to
371e217
Compare
svix-jplatte
temporarily deployed
to
Coverage
GitHub Actions
Inactive
svix-jplatte
changed the title
|
@djc can you publish the release? (not that urgent but I think it's confusing with the version bump merged + not released) |
2 participants
… that can panic because of invalid user input.
Closes #1773.