Skip to content

Implication of increasing Symbol name size to 16 bytes #25

Open

Description

@ang-st

Hi @chronoxor,

While we wanted to add a market pair with 10 letters, we recently noticed that Symbol name is defined as 8 bytes.

What we thought could be an easy fix (just make char Name[16]) seems to have implication as there are some places where code is optimized with unrolling and bit manipulations.

Before we patch it (and eventually propose it upstream) we wanted to clarify if that kind of change could impact code mechanical sympathy and as we are not high performance cpp expert by any means, wanted you opinion on the matters

Regards

Activity

  1. chronoxor commented on Dec 13, 2021

    @chronoxor
    Owner

    I see no problem with it. You'll see no difference until you measure nanoseconds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions