Skip to content

workflows: fix release image display digest step#4233

Merged
mtardy merged 1 commit intomainfrom
pr/mtardy/fix-release-ci-workflow
Oct 24, 2025
Merged

workflows: fix release image display digest step#4233
mtardy merged 1 commit intomainfrom
pr/mtardy/fix-release-ci-workflow

Conversation

@mtardy
Copy link
Copy Markdown
Member

@mtardy mtardy commented Oct 22, 2025

Docker build push action thought it was a good idea to add a build summary and uploading artifacts that can't be downloaded via the GitHub actions/download-artifact so we need to adapt each of our workflows.

See https://github.com/docker/build-push-action?tab=readme-ov-file#summaries and actions/toolkit#1874.

@mtardy mtardy requested a review from a team as a code owner October 22, 2025 11:50
@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label Oct 22, 2025
@mtardy mtardy requested a review from kevsecurity October 22, 2025 11:50
@FedeDP
Copy link
Copy Markdown
Contributor

FedeDP commented Oct 22, 2025

What about setting the DOCKER_BUILD_SUMMARY env variable to false instead?

Summaries are enabled by default, but can be disabled with the DOCKER_BUILD_SUMMARY environment variable.

https://github.com/docker/build-push-action?tab=readme-ov-file#environment-variables

Perhaps even DOCKER_BUILD_RECORD_UPLOAD might work fine if we want to retain the summary but kill the upload (?)

EDIT: either case, we could just set them as repository-wide envs and we should be good to go, without touching any workflow.

@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Oct 22, 2025

Perhaps even DOCKER_BUILD_RECORD_UPLOAD might work fine if we want to retain the summary but kill the upload (?)

oh this is what I was looking for but in the args not in the env variables

Docker build push action thought it was a good idea to add a build
summary and uploading artifacts that can't be downloaded via the GitHub
actions/download-artifact so we need to adapt each of our workflows.

See https://github.com/docker/build-push-action?tab=readme-ov-file#summaries
and actions/toolkit#1874.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/fix-release-ci-workflow branch from 0b00682 to 22be4f8 Compare October 22, 2025 15:45
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 22, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 22be4f8
🔍 Latest deploy log https://app.netlify.com/projects/tetragon/deploys/68f8fc31ff8d330008d2da1b
😎 Deploy Preview https://deploy-preview-4233--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Oct 22, 2025

You're right, I set up the DOCKER_BUILD_RECORD_UPLOAD variable repository wide

@mtardy mtardy closed this Oct 22, 2025
@mtardy mtardy deleted the pr/mtardy/fix-release-ci-workflow branch October 22, 2025 15:54
@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Oct 22, 2025

@FedeDP
Copy link
Copy Markdown
Contributor

FedeDP commented Oct 23, 2025

Check build summary support
Build summary supported!

I did not expect anything different 🤣
That's weird btw, seems like the action is not seeing DOCKER_BUILD_RECORD_UPLOAD=false being set :/

EDIT: it just checks process.env.FOO: https://github.com/docker/build-push-action/blob/9e436ba9f2d7bcd1d038c8e55d039d37896ddc5d/src/main.ts#L277

@mtardy mtardy restored the pr/mtardy/fix-release-ci-workflow branch October 23, 2025 08:57
@mtardy mtardy reopened this Oct 23, 2025
@mtardy mtardy merged commit 9309d69 into main Oct 24, 2025
96 checks passed
@mtardy mtardy deleted the pr/mtardy/fix-release-ci-workflow branch October 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants