Skip to content

Conversation

@nbmsc
Copy link
Contributor

@nbmsc nbmsc commented Jul 8, 2023

decision

form_teutonic_order

  • allow emperor of HRE to see the decision

create_archduchy_of_austria

  • allow child to see the decision
  • fix requirement for d_salzburg d_tyrol

prepare_coronation_ceremony

  • fix the trigger

donate_money_to_knights_santiago
donate_money_to_knights_calatrava

  • fix the culture check

feast_0

  • block the decision if already did it recently

events

  • fix the possessed option in HF.120 (gain trait of bloodline founder)
  • do not send HF.24210 (notify other players of alexander bloodline) to
    yourself
  • fix trigger in HF.40090 (bad papal saint)
  • fix option trigger in 72008 (hunt boar for feast)
  • check is_pregnant against ROOT in 72076 (friendly with guest's spouse)
  • fix 72086 (claim on guest's title)
  • use is_capital for 39640 (rise of shi'a caliphate)
  • should lose zealous in 74040 (mages and divinators visits the fair)
  • do not set unused flag prepare_fallback_event
  • prevent invasion of empty target in JD.10100
  • refresh business trade route modifier properly
  • update localisation key for secretly convert to aztec/bon

fix some friend rival events and family stuff

  • let AI consider family focus when they have living spouse
  • fix beloved target score value for spouse
  • allow to think of spouse in HFP.11001 (killed in battle)
  • use correct flag sway_hunting
  • fix option trigger in LT.20405 (use_secluded_upgrade target)
  • fix 100170 (my friend's friend is my friend) event target
  • fix 100411 (ask liege to allow duel with rival) combat not firing

nbmsc added 2 commits July 8, 2023 09:45
- let AI consider family focus when they have living spouse
- fix beloved target score value for spouse
- allow to think of spouse in HFP.11001 (killed in battle)
- use correct flag sway_hunting
- fix option trigger in LT.20405 (use_secluded_upgrade target)
- fix 100170 (my friend's friend is my friend) event target
- fix 100411 (ask liege to allow duel with rival) combat not firing
form_teutonic_order
- allow emperor of HRE to see the decision

create_archduchy_of_austria
- allow child to see the decision
- fix requirement for d_salzburg d_tyrol

prepare_coronation_ceremony
- fix the trigger

donate_money_to_knights_santiago
donate_money_to_knights_calatrava
- fix the culture check

feast_0
- block the decision if already did it recently

events
- fix the possessed option in HF.120 (gain trait of bloodline founder)
- do not send HF.24210 (notify other players of alexander bloodline) to
  yourself
- fix trigger in HF.40090 (bad papal saint)
- fix option trigger in 72008 (hunt boar for feast)
- check is_pregnant against ROOT in 72076 (friendly with guest's spouse)
- fix 72086 (claim on guest's title)
- use is_capital for 39640 (rise of shi'a caliphate)
- should lose zealous in 74040 (mages and divinators visits the fair)
- do not set unused flag prepare_fallback_event
- prevent invasion of empty target in JD.10100
- refresh business trade route modifier properly
- update localisation key for secretly convert to aztec/bon
Copy link
Contributor

@schwarherz schwarherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need these comments addressed before I can approve this

nbmsc added 5 commits July 13, 2023 13:19
hold_a_epic_tournament
- remove unnecessary owns location check

hold_a_furusiyya
- add missing nomad check
- remove unnecessary owns location check
- remove redundent do_not_disturb check

become_samrat_chakravartin
- remove redundent independent check

form_the_hre_early
- add missing independent check
- remove duplicate ill effect
- check the correct flag death_murder_poison
- delay death to let the event chain completes
@nbmsc
Copy link
Contributor Author

nbmsc commented Jul 30, 2023

decision: hide the false secretly convert to bon

secretly_convert_to_bon_pagan_holy_site
secretly_convert_to_bon_pagan_reformed_holy_site

  • check the flag has_been_reformed

decision: fix some potential checking

hold_a_epic_tournament

  • remove unnecessary owns location check

hold_a_furusiyya

  • add missing nomad check
  • remove unnecessary owns location check
  • remove redundent do_not_disturb check

become_samrat_chakravartin

  • remove redundent independent check

form_the_hre_early

  • add missing independent check

events: fix 100522 poison rival at feast

  • remove duplicate ill effect
  • check the correct flag death_murder_poison
  • delay death to let the event chain completes

@schwarherz schwarherz merged commit 07dae13 into ck2plus:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants