Skip to content

eduction: fix trait gained and clean up flags #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schwarherz merged 2 commits into from
Jul 12, 2023
Merged

eduction: fix trait gained and clean up flags #169

schwarherz merged 2 commits into from
Jul 12, 2023

Conversation

@nbmsc
Copy link
Contributor

@nbmsc nbmsc commented Jul 8, 2023

on_adulthood

  • fix character gaining 2 traits from 1 childhood trait because of the
    extra clean up event
  • also clean up rowdy_*_to_* flags
  • do not set achievement_follow_me when not ironman

introduce_heir

  • check and clear the correct flags

nbmsc added 2 commits July 8, 2023 09:47
@nbmsc
on_adulthood: fix trait gained and clean up flags
55f39bd 
- fix character gaining 2 traits from 1 childhood trait because of the
  extra clean up event
- also clean up rowdy_*_to_* flags
- do not set achievement_follow_me when not ironman
@nbmsc
introduce_heir: check and clear the correct flags
7fdedb9
@schwarherz schwarherz merged commit 5e7d8e0 into ck2plus:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schwarherz schwarherz schwarherz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbmsc @schwarherz