Misc smaller fixes (see individual commits for details) #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As previously implemented, "the Messenger" could also be from non-DW societies
The flag checked for in the ambition is now set when it is completed
Seeing as plot_gain_liege_title_decision_100 is better than plot_gain_liege_title_decision_75, the latter should probably not be visible when the former is possible
Might be slight overkill, but spouses most definitely shouldn't see that someone is cheating due to a modifier...
Vanilla consistency: Non-viceroy vassals are once again permitted to swap to Primo.
Presumably, only theocratic ones should be blocked
Proper add_trait_<trait>_effects (and related scripted_effects).
Seems bad to invalidate the wars in question because the title implodes...
Imprisoned/inaccessible/incapable women no longer think they're fit for the council.
Imprisoned/incapable/inaccessible DWs should not be randomly hunted down.
Incapable/inaccessible courtiers should not ask for nicknames, and imprisoned/incapable/inaccessible hosts should not be asked for them.
Preventing notifications for saints' tombs when they are irrelevant.
Concubines' pregnancies can no longer cause both the "Great!" and the "But I was away, wasn't I?" events for the same pregnancy.
Swaying/Antagonizing no longer results in actual sub-chains if you or your target is inaccessible, incapable, or imprisoned (things can get weird in various ways otherwise).
Priests flirted with at confession now need to explicitly be adults (regent checks could be bypassed by the game rule).
Fixed issue with being asked to refound the " " society when no longer showing interest in a society
No more improper Pilgrim traits
No buying your spouse a horse while in seclusion
- No stealing skulls abroad. - Characters are not assumed to be accessible just because they once were. - Attraction check from both directions in lover event.
- Characters with secret religions or that are flagged to not convert should not randomly pick up vile heresies. - Characters flagged to not convert should not convert to others' vile heresies. - Courtiers with secret religions should also not flip to others' vile heresies.
schwarherz
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to some assorted issues discovered through Tianxia.