Misc fixes and improvements #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an out of order Bon icon in religion_icon_strip.dds (CleanSlate error) religion_icon_strip_big and religion_icon_strip_small were correct however
WoL.3010, Relations with the spouse improved, can no longer fire for unlanded spouses unless they are at your court, e.g. they haven't run away or been imprisoned.
Fixed the strategist teaching a trait notification showing a random description (CleanSlate error)
Fixed consumption being less rather than more likely for unimportant characters (CleanSlate error)
Moved all references to the secret_*_community province modifiers to a single scripted trigger and scripted effect file, for ease of moddability. Moved artifact generation for when a smith steals the crafted artifact to a scripted effect for ease of moddability.
Sorted a pair of ambitions into the appropriate dlc files
You can now only select provinces with claimable title when using the Fabricate Claim action. Fixed non-Catholic characters being unable to fabricate a claim on the Pope's demesne. (CleanSlate error) Fixed a bad condition in spymaster.201 'Spymaster finds Faction Member' (CleanSlate error)
Fixed incorrect weights for candidate Piety in elective succession voting (CleanSlate error) Fixed rulers trusting their own judgement in elective succession voting because they are just, etc. Fixed stat values between 25 and 29 not having any candidate score weight in elective succession voting.
Fixed byzantine commander requirements not being shown in the Appoint Commander decision tooltip (CleanSlate error) Fixed can_still_be_marshal_byzantine_trigger checking for the wrong special councillor flag (CleanSlate error) Fixed MNM.70005 showing the wrong option localisation (CleanSlate error) Vassal mercenary leaders are no longer selectable as commanders, since they could be appointed to lead armies anyway
Fixed claim cb checking gender succession on the wrong characters title (CleanSlate error) Fixed province prosperity icons being broken (Cleanslate error) Fixed weirdly desaturated Egyptian female cheeks. Fixed the City Milita Training Grounds buildings being shown as being unlocked by "Cities and Temples" rather than "Improved Keeps" Temples use and are displayed under "Cities and Temples", while Castles use and are displayed under "Improved Keeps". Unsure if we should try to force some consistency here?
Mercenaries can no longer use the order_to_take_vows and order_to_join_holy_order decisions. Holy Orders can no longer use the order_to_take_vows. Holy Order members can no longer be ordered to join a Holy Order.
Fixed trusting characters not receiving pregnancy notifications from their consorts (CleanSlate error) Fixed bad ai_chance in event 74040 (CleanSlate error) Fixed scoping errors in WoL.2210, the Liberate outcome tombola event (CleanSlate error) Fixed broken localisation command in MNM.4431, saint's fingerbone reward (CleanSlate error) Hopefully the demon child nanny will stick with her charge now? Holy Orders demanding a child as a loan repayment can now only ask for children at your court. LT.20010, finding a lost book, can no longer select ill or incapable characters as emissaries, and will no fire while you are imprisoned. MNM.9136, Smith makes ward stronger, now prefers actual wards over random prisoners in house arrest. Fixed the Varangian child outcome events not checking if the child can actually marry before marrying them Fixed the Varangian child outcome events spouses ending up in the wrong court Fixed EVTDESC_WOL_10116 assuming the steward is a man. Not sure if the non-English languages have gender errors. Reverted WoL.5040 Option C effects to match vanilla effects again (CleanSlate error) Reverted inefficient and incorrect use some trait effects in wol_hunting_events (CleanSlate error)
Also some minor optimizations.
Made it significantly easier for mods like City of Wonders to integrate wonder variants by replacing most instances of has_wonder/has_wonder_upgrade with has_wonder_flag has_wonder_upgrade_flag, as well as adding flags to every wonder and wonder_upgrade derived from their name. Fixed Grand Harbors and Lighthouses having the wrong background (CleanSlate Error)
Aside from the silly Muslim check, especially because the Status of Women laws in Conclave make female Muslim rulers perfectly possible (not to mention the fixed vanilla bug that allowed female Muslim claimants in the claimant faction)
And fixed 'trigger' logic to be functionally identical to vanilla's original logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.